Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8689: Captions for illustrations on special pages #1138

Merged
merged 6 commits into from
Dec 17, 2024
Merged

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Dec 13, 2024

UHF-8689

What was done

  • Add reusable template and styles for special page illustrations.
  • Convert error pages, maintenance page and login page to use it.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-8689
  • Run make drush-cr

How to test

  • Go to /user/login and make sure that the illustration still looks good on the page (compare it to for example some production page). Make sure that there is now also the name of the creator of the illustration. The figcaption should always be aligned to the left.
  • Do the same check for /asfdsgdfhsdh page which is the 404-error page.
  • Next do the same check for /admin when you are not logged in which is the 403-error page.
  • Lastly log in to the site and put it to maintenance mode and go see the page in incognito window. Check the same thing for the illustration there. You can compare this for example to some other instance on your local that you can also put to maintenance mode.
  • Check that code follows our standards.

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Sami Haikonen)

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

@juho-lehmonen juho-lehmonen self-requested a review December 16, 2024 10:14
Copy link

✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1138/html_report/

Copy link
Contributor

@juho-lehmonen juho-lehmonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants