Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10757 #1123

Merged
merged 5 commits into from
Dec 4, 2024
Merged

UHF-10757 #1123

merged 5 commits into from
Dec 4, 2024

Conversation

rpnykanen
Copy link
Contributor

@rpnykanen rpnykanen commented Dec 2, 2024

UHF-10757

Fixed a bunch of javascript errors from sentry;

  • UHF-10755: SecurityError (localstorage usage on incognito might cause this error)
  • UHF-10757: ResizeObserver and UnhandeldRejection (caused by third party most likely. UnhandledRejection errors might be caused by outlook safelink crawler )
  • UHF-9969 Finally remove the localstorage cleaner from the codebase.

Also, running npm build update all of the minified react codes.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-10757
  • Run make drush-cr

How to test

  • Test that localstorage is still working (accordion for example)
  • Browse the site a bit and javascript features should work as expected
  • Test one or more of the react-searches

Copy link

github-actions bot commented Dec 2, 2024

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1123/html_report/

@juho-lehmonen juho-lehmonen self-requested a review December 3, 2024 07:24
Copy link
Contributor

@juho-lehmonen juho-lehmonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tested accordions etc on the Strategia instance and react searches on the KASKO instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants