Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10535: updated typography variables, added letter spacing #1122

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

annadruid
Copy link
Contributor

@annadruid annadruid commented Dec 2, 2024

UHF-10535

What was done

  • Changed typography line heights and added letter spacing to some

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-10535
  • Run make drush-cr

How to test

  • Check that text looks good especially for h1, h2, h3, h4, h5, h6 (easiest to create a page with different headings, body etc)
  • Check that code follows our standards

This PR has been checked with a designer and approved by them!

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Copy link

github-actions bot commented Dec 2, 2024

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1122/html_report/

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very nice 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants