Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10973: Cache in _hdbt_set_image_style #1115

Merged
merged 1 commit into from
Nov 20, 2024
Merged

UHF-10973: Cache in _hdbt_set_image_style #1115

merged 1 commit into from
Nov 20, 2024

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented Nov 20, 2024

UHF-10973

What was done

  • Handle cache tags in _hdbt_set_image_style.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-10973
  • Run make drush-cr
  • Make sure cache is not disabled in local.{settings.php,services.yml}.

How to test

  • Changing field_image_gallery_ratio in image gallery paragraph works without clearing caches.
  • Changing field_original_aspect_ratio in image paragraph works without clearing caches.
  • Changing field_hero_design in hero paragraph works without clearing caches.
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

  • Link to other PR

Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1115/html_report/

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly in all three cases. Excellent! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants