Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-X chat button position #1114

Merged
merged 3 commits into from
Dec 4, 2024
Merged

UHF-X chat button position #1114

merged 3 commits into from
Dec 4, 2024

Conversation

Arkkimaagi
Copy link
Contributor

@Arkkimaagi Arkkimaagi commented Nov 18, 2024

UHF-X

  • The chat button floats either behind or in front of the cookie banner. The former is bad due to accessibility tabbing visibility requirement and the latter for covering the banner content.
    image

What was done

  • A code was added to move the button from behind or front of the banner above it.
    image

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-X_chat_button_position
  • Run make drush-cr

How to test

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1114/html_report/

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works! 🚀

@Arkkimaagi Arkkimaagi force-pushed the UHF-X_chat_button_position branch from e3e0bfa to 8afa999 Compare December 4, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants