Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8340: Fixed remote video cookie compliance colors #1113

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

annadruid
Copy link
Contributor

@annadruid annadruid commented Nov 18, 2024

UHF-8340

What was done

  • Fixed cookie compliance colors for remote video
  • Changed map background color to black-5
  • Changed cookie compliance to use black-10

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-8340_cookie_compliance_color_fix
  • Run make drush-cr

How to test

  • Don't accept the cookies when going to the site
  • Add a remote video for example to article page, the cookie compliance should now be readable
  • Add a map and make sure the background color looks ok
  • Find a page that has react and share, check that the colors for that are also okay
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1113/html_report/

Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1113/html_report/

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants