Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10619: Double space in hakuvahti keyword will make the hakuvahti useless. #1099

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

rpnykanen
Copy link
Contributor

@rpnykanen rpnykanen commented Oct 30, 2024

UHF-10619

What was done

Prevent adding double space in job search keyword.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-10619
  • Run make drush-cr

How to test

  • Go to job search and try to add double space to the keyword field.
    It should not be possible to add 2 spaces to search keyword.
  • Check that this feature works
  • Check that code follows our standards

Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1099/html_report/

@khalima khalima added the recreate-reference-images Use this label to re-create reference images used by Visual regression tests label Oct 31, 2024
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1099/html_report/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
recreate-reference-images Use this label to re-create reference images used by Visual regression tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants