Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-8650 Pre cleaning #1093

Merged
merged 1 commit into from
Oct 28, 2024
Merged

UHF-8650 Pre cleaning #1093

merged 1 commit into from
Oct 28, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Oct 28, 2024 •
edited by jira bot
Loading

UHF-8650

What was done

  • Change the way to load EU cookie compliance libraries to surpress the "The following theme is missing from the file system: eu_cookie_compliance".

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-8650_pre_cleaning
  • Run make drush-cr

How to test

  • Check that the EU cookie compliance libraries gets loaded as before.
  • Check that code follows our standards

@khalima
UHF-8650: Change the way to load EU cookie compliance libraries to su…
15c7cf8 
…rpress the "The following theme is missing from the file system: eu_cookie_compliance".
teroelonen
teroelonen approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good 🦖

@github-actions GitHub Actions
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1093/html_report/

@khalima khalima merged commit 994b217 into main Oct 28, 2024
2 checks passed
@khalima khalima deleted the UHF-8650_pre_cleaning branch October 28, 2024 08:38
This was referenced Oct 28, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khalima @teroelonen