Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8833: Change Askem-features no-cookies texts #1089

Merged
merged 2 commits into from
Oct 21, 2024
Merged

UHF-8833: Change Askem-features no-cookies texts #1089

merged 2 commits into from
Oct 21, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Oct 18, 2024

UHF-8833

What was done

  • Changed the texts that are displayed on the Askem block when cookies are not allowed by the user.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-8833
  • Run make drush-locale-update drush-cr

How to test

  • Go to any page on your testing instance that has the Askem (React & Share) block enabled and make sure you don't have cookies approved.
  • The block should now say:
    FI
    Haluatko antaa meille palautetta tästä sivusta?
    Pääset antamaan palautetta, jos sallit evästeasetuksista tilastointiin liittyvät evästeet.
    SV
    Vill du ge oss feedback om denna sida?
    Du kan ge oss feedback genom att aktivera statistikrelaterade cookies.
    EN
    Would you like to give feedback on this page?
    Enabling cookies that collect statistics will allow you to share your input.
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1089/html_report/

@juho-lehmonen juho-lehmonen self-requested a review October 18, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants