Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9998 link size #1088

Merged
merged 15 commits into from
Oct 28, 2024
Merged

UHF-9998 link size #1088

merged 15 commits into from
Oct 28, 2024

Conversation

Arkkimaagi
Copy link
Contributor

@Arkkimaagi Arkkimaagi commented Oct 18, 2024

UHF-9998

  • Link size is not large enough for latest WCAG requirements
    • 24px is our hard requirement for our AA-level
    • 44px would be better where possible, it's the AAA-level minimum

What was done

  • Link clickable area sizes increased
    • Header top (news, rekry, etc) 44px
    • Language links 44px
    • Nav toggle buttons min 44px (search, menu, etc)
    • site name 44px
    • breadcrumb link 44px
    • footer logo clickable area 44px (logo is still 40px)
    • footer top links 44px
    • footer bottom links 44px
    • "back to top" link 44px
    • sidebar link size to 44px
    • accordion toggle all button size to 44px
    • map link button to 44px
    • unit-contact-card to 44px
    • pagination link to 44px
    • popular service item links to 44px

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-9998_link_size
  • Run make drush-cr

How to test

  • Check that links still look sane with minimal visual changes (but clickable area is bigger)
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

@Arkkimaagi Arkkimaagi marked this pull request as ready for review October 25, 2024 13:26
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1088/html_report/

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small bug with the menu and search toggle on mobile but otherwise did everything it promised:
Screenshot 2024-10-25 at 17 38 07

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works perfectly now! Really nice work on these links 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants