Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10276: Replace old dialog.js implementation from forms #1084

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Oct 15, 2024

UHF-10276

What was done

  • Refactored survey and dialog to use same styles.

How to install

  • Check installation instructions from the grants PR

How to test

  • Check testing instructions from the grants PR
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Other PRs

Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1084/html_report/

Copy link

@jiisuominen jiisuominen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on Grants PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants