UHF-8650 Preparation for the HDS cookie banner module

[khalima]

UHF-8650

This PR mostly tackles the issues when either of the EU Cookie compliance or HDBT cookie banner modules are installed. Hence the massive amount of todo comments.

What was done

• Updated the cookie policy/settings URL to be retrieved from hdbt_cookie_banner module.
• Use cookie settings service to retrieve the privacy policy url and rely on hdbt_cookie_banner_page_attachments() to handle the react search URL.
• Use HDBT cookie banner cookie settings URL if available. Otherwise, fallback to helfi_eu_cookie_compliance private policy URL.
• Changed the cookie-policy template name to cookie-settings page.
• Added possibility to use the hdbt_cookie_banner settingsPageUrl variable.

How to install

• Install at least the following instances: Etusivu, KYMP, SOTE
  • git pull origin dev
  • make fresh
• Update the Helfi platform config and HDBT theme
  • composer require drupal/helfi_platform_config:dev-UHF-8650 drupal/hdbt:dev-UHF-8650 -W
• Run make drush-cr

How to test

Etusivu

Testing instructions for the EU Cookie Compliance module

• Create a standard page with Map, Video embed and Chart paragraphs
• Explore the page in incognito and accept only necessary cookies.
  • Reload the page and check that all paragraphs have the Content cannot be displayed messages.
  • Accept the cookies from the cookie settings page and reload the page above. Check that the paragraphs work as they should.

Testing instructions for the HDBT Cookie banner module

• Enable and configure the hdbt_cookie_banner module and uninstall the eu_cookie_compliance module.
  • Run make shell and in shell drush en -y hdbt_cookie_banner && drush pmu -y eu_cookie_compliance
  • Go to https://helfi-etusivu.docker.so/fi/admin/structure/hdbt-cookie-banner
  • Select "Use instance specific cookie settings" checkbox.
    • This will make the Drupal use the instance specific cookie settings and cookie banner javascript
  • Override the contents of this file to Site settings textarea: sitesettings.json
  • Save the changes and clear caches.
• Explore the standard page (created in first step) in incognito and accept only necessary cookies.
  • Reload the page and check that all paragraphs have the Content cannot be displayed messages.
  • Accept the cookies from the cookie settings page and reload the page above. Check that the paragraphs work as they should.

KYMP

Testing instructions for the EU Cookie Compliance module

• Create a standard page with Map, Video embed, Chart and a Journey planner paragraphs
• Explore the page in incognito and accept only necessary cookies.
  • Reload the page and check that all paragraphs and the "react and share" block have the Content cannot be displayed messages.
  • Accept the cookies from the cookie settings page and reload the page above. Check that the paragraphs work as they should.

Testing instructions for the HDBT Cookie banner module

• Enable and configure the hdbt_cookie_banner module and uninstall the eu_cookie_compliance module.
  • Run make shell and in shell drush en -y hdbt_cookie_banner && drush pmu -y eu_cookie_compliance
  • Go to https://helfi-kymp.docker.so/fi/admin/structure/hdbt-cookie-banner
  • Check that the "Use instance specific cookie settings" checkbox is unchecked.
    • This will make the Drupal use the "helfi-etusivu" API URL and will load the HDS cookie consent JS library from the "helfi-etusivu"
  • Save the changes and clear caches.
• Explore the standard page (created in first step) in incognito and accept only necessary cookies.
  • Reload the page and check that all paragraphs have the Content cannot be displayed messages.
  • Accept the cookies from the cookie settings page and reload the page above. Check that the paragraphs work as they should.

SOTE

Testing instructions for the EU Cookie Compliance module

• Create a standard page with Map, Video embed, Chart and a Journey planner paragraphs
• Explore the page in incognito and accept only necessary cookies.
  • Reload the page and check that all paragraphs have the Content cannot be displayed messages.
  • Go to https://helfi-sote.docker.so/fi/sosiaali-ja-terveyspalvelut/terveydenhoito/hammashoito and check that the "Hammashoidon chat" works - it should accept the chat consent category as before
  • Accept the cookies from the cookie settings page and reload the page above. Check that the paragraphs work as they should.

Testing instructions for the HDBT Cookie banner module

• Enable and configure the hdbt_cookie_banner module and uninstall the eu_cookie_compliance module.
  • Run make shell and in shell drush en -y hdbt_cookie_banner && drush pmu -y eu_cookie_compliance
  • Go to https://helfi-sote.docker.so/fi/admin/structure/hdbt-cookie-banner
  • Check that the "Use instance specific cookie settings" checkbox is unchecked.
    • This will make the Drupal use the "helfi-etusivu" API URL and will load the HDS cookie consent JS library from the "helfi-etusivu"
  • Save the changes and clear caches.
• Explore the standard page (created in first step) in incognito and accept only necessary cookies.
  • Reload the page and check that all paragraphs have the Content cannot be displayed messages.
  • Go to https://helfi-sote.docker.so/fi/sosiaali-ja-terveyspalvelut/terveydenhoito/hammashoito and check that the "Hammashoidon chat" works - it should accept the chat consent category as before
  • Accept the cookies from the cookie settings page and reload the page with all the paragraph. Check that the paragraphs work as they should.

Other

• Check that code follows our standards

Other PRs

• UHF-8650 Preparation for the HDS cookie banner module drupal-helfi-platform-config#832

[github-actions]

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1083/html_report/

[github-actions]

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1083/html_report/