Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9508 & UHF-10769: Change unit contact card layout and improve accessibility #1082

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

j-mys
Copy link
Contributor

@j-mys j-mys commented Oct 11, 2024

UHF-9508 & UHF-10769

Change unit contact card layout

What was done

  • CSS and DOM changes for the unit contact card paragraph.
  • Add unit name for the link to unit page for screen readers to help with link context.

How to install

  • Make sure your instance (developed with KASKO) is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-9508-unit-contact-card
  • Update the helfi_platform_config
    • composer require drupal/helfi_platform_config:dev-UHF-9508-unit-contact-card
  • Run make drush-updb drush-locale-update drush-cr

How to test

  • Go to page containing unit contact cards or add one to
    • landing page
    • content page
  • Compare with design
  • Try out different info amounts, with and without image and on different screen widths
  • Make sure the responsive image styles for the unit contact card now match with the new styles. It should use same image styles as card uses since the layout is very similar.
  • Make sure the unit contact card link says now See details / Katso tarkemmat tiedot / Se detaljer instead of the old Unit homepage text.
  • Make sure there is visually hidden text on the link that adds the units title there to help screen readers give some context to their users.
  • Check that code follows our standards

Continuous documentation

  • This change doesn't require updates to the documentation

Other PRs

@teroelonen teroelonen changed the title change unit contact card layout UHF-9508: Change unit contact card layout Oct 11, 2024
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1082/html_report/

@teroelonen teroelonen changed the title UHF-9508: Change unit contact card layout UHF-9508 & UHF-10769: Change unit contact card layout and improve accessibility Oct 14, 2024
Copy link
Contributor

@Arkkimaagi Arkkimaagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as it should, code looks clean and it's an improvement all over. Good job you two!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants