Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-X Visual regression fix #1068

Merged
merged 12 commits into from
Oct 10, 2024
Merged

UHF-X Visual regression fix #1068

merged 12 commits into from
Oct 10, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Oct 7, 2024 •
edited
Loading

What was done

  • Updated dotenv to use @dotenvx/dotenvx
  • Updated @sentry/react to latest version
  • Minor fixes to visual regression action

How to test

  • Check that the visual regression tests run (and get installed) correctly
  • Check that code follows our standards

@khalima khalima added the recreate-reference-images Use this label to re-create reference images used by Visual regression tests label Oct 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1068/html_report/

@khalima khalima removed the recreate-reference-images Use this label to re-create reference images used by Visual regression tests label Oct 7, 2024
teroelonen
teroelonen approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good for now 🦖

@teroelonen teroelonen merged commit 0fbbd5c into main Oct 10, 2024
2 checks passed
@teroelonen teroelonen deleted the UHF-X_visual_regression_fix branch October 10, 2024 06:56
This was referenced Oct 11, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khalima @teroelonen