Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10397: Fix spacing on news listings #1066

Merged
merged 2 commits into from
Oct 7, 2024
Merged

UHF-10397: Fix spacing on news listings #1066

merged 2 commits into from
Oct 7, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Oct 4, 2024

UHF-10397

What was done

  • Removed styling that was apparently causing issues on news listings.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-10397
  • Run make drush-cr

How to test

  • Check that the component news list that is found on all instances (excluding etusivu-instance) front pages doesn't have the extra margin on items on top anymore. Compare the layout to the etusivu-instance latest news component and the spacing should be the same on the items there.
  • The removed styling was vague not-selector that could affect a lot of places so there is possibility that something else broke now that it is gone so have a general look around on front page instance and maybe KASKO (they have normal news block and high school news) that everything still looks good.
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Copy link

github-actions bot commented Oct 4, 2024

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1066/html_report/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants