UHF-8670 Hero image author #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
|
Arkkimaagi
requested changes
Sep 23, 2024
| } | ||
|
|
||
| .hero__image-author { | ||
| position: absolute; |
There was a problem hiding this comment.
This position: absolute can be dangerous. What's the maximum limit for photographer field? I mean, it could go bad sideways if there's a long photographer info.
…ttributes for the figcaption.
…as the "Arrow" design element will hide the on mobile width.
Arkkimaagi
reviewed
Sep 23, 2024
| // Hero image author styles. | ||
| .hero__image-author { | ||
| // Arrow element width. | ||
| margin-left: 100px; |
There was a problem hiding this comment.
Instead of a comment I'd put this value into a descriptive css variable (custom property) like --arrow-element-width: 100px, so that I could use it both in the regular and in the [dir="rtl"] cases.
Arkkimaagi
reviewed
Sep 23, 2024
… text-align:end doesn't work in our case. The fallback language [dir=ltr] will make the text appear on the 'wrong' side.
Arkkimaagi
approved these changes
Sep 24, 2024
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UHF-8670
What was done
How to install
git pull origin devmake freshcomposer require drupal/helfi_platform_config:dev-UHF-8670 drupal/hdbt:dev-UHF-8670make drush-updb drush-crHow to test
Go to some page with Hero and check that the image author text has appeared. See screenshot below.
Check that code follows our standards
Continuous documentation
Translations
Other PRs