Footer Js libraries should not have dependencies to header libraries #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
khalima
approved these changes
Sep 19, 2024
This was referenced Sep 19, 2024
hyrsky
added a commit
to City-of-Helsinki/drupal-helfi-etusivu
that referenced
this pull request
Oct 3, 2024
While debugging City-of-Helsinki/drupal-hdbt#1049, I had a breakpoint on hook_file_url_alter(), and noticed that paragraph rendering causes a lot of invocations. I don't think this is a real issue, but it is still not best practice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UHF-0000
What was done
Core moves dependencies of header library to header. However, this does not appear to happen the other way, dependencies of footer libraries are not moved to the footer. JsAssetController loads only the libraries in current scope (header or footer). If some dependencies are missing, the asset hashes do not match, and the asset controller triggers a redirect response. Redirect response paths do not go through
hook_file_url, so our proxy settings don't get triggered.How to install
git pull origin devmake freshcomposer require drupal/hdbt:dev-UHF-X-footer-js-librariesmake drush-crHow to test
Continuous documentation
Translations
Other PRs