Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10171: Align link buttons and buttons text always on center #1039

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Aug 13, 2024

UHF-10171

What was done

  • Aligned link buttons and buttons text always on center.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-10171_popup_layout_fixes
  • Run make drush-cr

How to test

  • Create a survey if you don't have one on you local already or sync database from testing where there is already one.
  • Make sure that the button texts are always aligned to center. Easily this can be checked on narrow screens.
  • Check that code follows our standards.

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1039/html_report/

Copy link
Contributor

@Arkkimaagi Arkkimaagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, HDS seems to miss this property too in its current and upcoming implementation of link buttons. I'll contact them as well. Approved 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants