Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-9946: Grants hdbt_subtheme refactoring and updating changes #1010

Merged
merged 6 commits into from
Jun 20, 2024
Merged

UHF-9946: Grants hdbt_subtheme refactoring and updating changes #1010

merged 6 commits into from
Jun 20, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Jun 14, 2024 •
edited
Loading

UHF-9946

What was done

  • Remove two deprecated stylelint rules.
  • Add two optional variables for the 401 page template for grants to use.

How to install

  • Check testing instructions from the Grants PR.

How to test

  • Check testing instructions from the Grants PR.
  • Check that code follows our standards.

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Other PRs

@teroelonen teroelonen mentioned this pull request Jun 14, 2024
Merged
6 tasks
@teroelonen teroelonen marked this pull request as ready for review June 14, 2024 15:02
@teroelonen teroelonen marked this pull request as draft June 14, 2024 15:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1010/html_report/

@teroelonen teroelonen marked this pull request as ready for review June 17, 2024 13:39
@teroelonen teroelonen requested a review from suvikankare June 20, 2024 12:36
@teroelonen teroelonen merged commit 6ea70e0 into main Jun 20, 2024
2 checks passed
@teroelonen teroelonen deleted the UHF-9946 branch June 20, 2024 12:41
This was referenced Jun 20, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suvikankare suvikankare suvikankare approved these changes

@hyrsky hyrsky hyrsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teroelonen @hyrsky @suvikankare