Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10104 Javascript fixes #1004

Merged
merged 4 commits into from
Jun 4, 2024
Merged

UHF-10104 Javascript fixes #1004

merged 4 commits into from
Jun 4, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Jun 4, 2024

UHF-10104

What was done

  • Switched linked events getDay() method to use getDate().
  • Load the hyphenopoly_loader in head.
  • Scratch the drupal behavior from hyphenopoly settings as it might mess up the loading of hyphenopoly.
  • Fixed Cannot read properties of null (reading 'dataset') error when browsing avustukset in mobile width.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-10104
  • Run make drush-cr

How to test

  • Check that the loading of hyphenopoly works without loading errors.
  • Check that code follows our standards

Copy link

github-actions bot commented Jun 4, 2024

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1004/html_report/

…rror when browsing avustukset in mobile width.
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants