Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-X Hyphenopoly fix #1000

Merged
merged 1 commit into from
Jun 3, 2024
Merged

UHF-X Hyphenopoly fix #1000

merged 1 commit into from
Jun 3, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented May 31, 2024

What was done

  • Check for the existence of Hyphenopoly global variable before setting configuration for it

How to test

  • Check that code follows our standards

teroelonen
teroelonen approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome 🦖

@github-actions GitHub Actions
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1000/html_report/

@khalima khalima merged commit 0733b0f into main Jun 3, 2024
2 checks passed
@khalima khalima deleted the UHF-X_hyphenopoly_fix branch June 3, 2024 13:03
This was referenced Jun 4, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khalima @teroelonen