UHF-5 Base theme #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teroelonen
requested changes
Nov 6, 2020
There was a problem hiding this comment.
Can't get the precommit hooks to work:
➜ hdbt git:(UHF-5_base_theme) ✗ git add . && git commit -m "My commit"
pre-commit:
pre-commit: We have nothing pre-commit hooks to run. Either you're missing the scripts
pre-commit: in your package.json or have configured pre-commit to run nothing.
pre-commit: Skipping the pre-commit hook.
pre-commit:
[UHF-5_base_theme 6cd08d2] My commit
4 files changed, 28 insertions(+), 25 deletions(-)
rewrite dist/css/styles.min.css (76%)
rewrite dist/icons/sprite.svg (88%)
teroelonen
approved these changes
Nov 6, 2020
hyrsky
added a commit
that referenced
this pull request
Feb 29, 2024
`total_rows` was not defined if $variables['view']->total_rows is zero, since `0 == NULL` evaluates to true. This patch ensures that total rows is always defined so templates can use it without checking.
hyrsky
added a commit
that referenced
this pull request
Mar 1, 2024
UHF-9566: Fix deprecated call abs(): Passing null to parameter #1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test:
nvm use && npm i && npx husky ito setup the build tools + lintersnpm run buildand check that thedistfolder has compiled content (css/js/sprite icons)git add . && git commit