Remove bordered card style

City-of-Helsinki · Dec 11, 2024 · 193ca99 · 193ca99
1 parent 7acf618
commit 193ca99
Show file tree

Hide file tree

Showing 13 changed files with 9 additions and 20 deletions.
diff --git a/dist/css/styles.min.css b/dist/css/styles.min.css
diff --git a/dist/js/district-and-project-search.min.js b/dist/js/district-and-project-search.min.js
diff --git a/dist/js/health-station-search.min.js b/dist/js/health-station-search.min.js
diff --git a/dist/js/job-search.min.js b/dist/js/job-search.min.js
diff --git a/dist/js/linkedevents.min.js b/dist/js/linkedevents.min.js
diff --git a/dist/js/maternity-and-child-health-clinic-search.min.js b/dist/js/maternity-and-child-health-clinic-search.min.js
diff --git a/dist/js/news-archive.min.js b/dist/js/news-archive.min.js
diff --git a/dist/js/school-search.min.js b/dist/js/school-search.min.js
diff --git a/src/js/react/apps/linkedevents/components/ResultCard.tsx b/src/js/react/apps/linkedevents/components/ResultCard.tsx
@@ -25,7 +25,7 @@ const getCardTags = ({ keywords, currentLanguage }: KeywordsForLanguage ) => key
 
 function ResultCard({ end_time, id, location, name, keywords=[], start_time, images, offers }: Event) {
   const { currentLanguage } = drupalSettings.path;
-  const { baseUrl, imagePlaceholder, useBorderedCards } = drupalSettings.helfi_events;
+  const { baseUrl, imagePlaceholder } = drupalSettings.helfi_events;
   const url = `${baseUrl}/${currentLanguage}/events/${id}`;
 
   const resolvedName = name?.[currentLanguage] || name?.fi || Object.values(name)[0] || '';
@@ -125,7 +125,6 @@ function ResultCard({ end_time, id, location, name, keywords=[], start_time, ima
       location={isRemote ? 'Internet' : getLocation()}
       time={getDate()}
       registrationRequired={getOffers()}
-      useBorderedCards={useBorderedCards}
     />
   );
 }

diff --git a/src/js/react/common/Card.tsx b/src/js/react/common/Card.tsx
@@ -75,13 +75,11 @@ function CardItem({
   weightedEducation,
   languageEducation,
   registrationRequired,
-  useBorderedCards,
 }: CardItemProps): JSX.Element {
   const cardClass = `
     card
     ${cardModifierClass ? ` ${cardModifierClass}` : ''}
     ${cardUrlExternal ? ' card--external' : ''}
-    ${useBorderedCards ? ' card--bordered' : ''}
   `;
   const HeadingTag = cardTitleLevel ? `h${cardTitleLevel}` as keyof JSX.IntrinsicElements : 'h3';
 

diff --git a/src/js/types/drupalSettings.d.ts b/src/js/types/drupalSettings.d.ts
@@ -31,7 +31,6 @@ declare namespace drupalSettings {
       }
     },
     seeAllButtonOverride: string,
-    useBorderedCards: boolean,
     useExperimentalGhosts: boolean,
   };
   const helfi_react_search: {

diff --git a/src/scss/05_objects/_card.scss b/src/scss/05_objects/_card.scss
@@ -3,7 +3,6 @@ $item-gap: $spacing-half;
 
 .card {
   background: $color-white;
-  border: 2px solid transparent;
   overflow-wrap: anywhere;
   padding: $spacing;
   position: relative;
@@ -29,11 +28,6 @@ $item-gap: $spacing-half;
 
 .card--ghost {
   background: $color-black-20;
-  border: none;
-}
-
-.card--bordered {
-  border: 2px solid $color-black-20;
 }
 
 .card__image {

diff --git a/src/scss/06_components/paragraphs/_react-search.scss b/src/scss/06_components/paragraphs/_react-search.scss
@@ -15,7 +15,6 @@
 
 .react-search__list-container {
   margin-bottom: $spacing-double;
-  scroll-behavior: smooth;
 }
 
 .react-search__list-container.loading .card {