Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-8650: Cookie banner #309

Merged
merged 1 commit into from
Nov 1, 2024
Merged

UHF-8650: Cookie banner #309

merged 1 commit into from
Nov 1, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Nov 1, 2024 •
edited by jira bot
Loading

UHF-8650

What was done

  • Added footer tag to page.html.twig to support the cookie banner in admin theme.

How to install

  • Make sure Etusivu or Sote instance is up and running on latest dev branch (and db from testing).
    • git pull origin dev
    • make fresh
  • Update the HDBT Admin theme
    • composer require drupal/hdbt_admin:dev-UHF-8650
  • Run make drush-cr

How to test

  • Check from the front page that the cookie banner gets loaded
  • Go to any admin page and check that the cookie banner gets loaded
  • Check that code follows our standards

@khalima khalima merged commit 5aef0b6 into main Nov 1, 2024
1 check passed
@khalima khalima deleted the UHF-8650 branch November 1, 2024 05:43
This was referenced Nov 1, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@khalima