Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency sass-loader to v16 #293

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 26, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
sass-loader ^14.0.0 -> ^16.0.0 age adoption passing confidence

Release Notes

webpack-contrib/sass-loader (sass-loader)

v16.0.1

Compare Source

Bug Fixes

v16.0.0

Compare Source

⚠ BREAKING CHANGES
  • use modern Sass JS API by default for sass and sass-embedded

[!WARNING]

The sass options are different for the legacy (before) and modern APIs. Please look at docs how to migrate to the modern options.
Legacy options - https://sass-lang.com/documentation/js-api/interfaces/legacystringoptions/
Modern options - https://sass-lang.com/documentation/js-api/interfaces/options/

To return to the previous logic use:

module.exports = {
  module: {
    rules: [
      {
        test: /\.s[ac]ss$/i,
        use: [
          "style-loader",
          "css-loader",
          {
            loader: "sass-loader",
            options: {
              api: "legacy",
              // Your options
            },
          },
        ],
      },
    ],
  },
};
Features
  • use modern Sass JS API by default for sass and sass-embedded (10be1ba)

v15.0.0

Compare Source

⚠ BREAKING CHANGES
  • prefer sass-embedded over sass by default (#​1211)
Features
14.2.1 (2024-04-16)
Bug Fixes

v14.2.1

Compare Source

v14.2.0

Compare Source

Features
  • added the modern-compiler value for API to reuse compiler process (#​1195) (cef40a8)
  • support webpack built-in resolver for modern and modern-compiler API (#​1197) (2265b72)

Notes:

Using the modern-compiler value for the api option together with sass-embedded reduces compilation time by 5-10 times, especially for projects using large files with a lot of @import/@use, for small files the build time reduction will not be significant.

14.1.1 (2024-02-19)
Bug Fixes

v14.1.1

Compare Source

v14.1.0

Compare Source

Features

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@khalima
Copy link
Contributor

khalima commented Sep 27, 2024

To update sass-loader, we would need to rethink the way CSS files are included and handled in webpack configuration.

Especially the css in xx_external folder. When we set the $debug_mode as an additional data, it will be prepended to the css files as well and the following error message will occur Sass variables aren't allowed in plain CSS..

@khalima khalima closed this Sep 27, 2024
Copy link
Contributor Author

renovate bot commented Sep 27, 2024

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 16.x releases. But if you manually upgrade to 16.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/sass-loader-16.x branch September 27, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant