Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-9690: Character counter #272

Merged
merged 11 commits into from
Mar 6, 2024
Merged

UHF-9690: Character counter #272

merged 11 commits into from
Mar 6, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Feb 27, 2024 •
edited
Loading

UHF-9690

What was done

  • Moved the logic to field widget and themed the character counter accordingly

How to install and test

Other PRs

@khalima khalima mentioned this pull request Mar 4, 2024
Merged
9 tasks
@khalima khalima marked this pull request as ready for review March 4, 2024 16:00
teroelonen
teroelonen approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, very good 🦖

@khalima khalima merged commit 35d6736 into main Mar 6, 2024
1 check passed
@khalima khalima deleted the UHF-9690 branch March 6, 2024 07:22
This was referenced Mar 6, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khalima @teroelonen