Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-8135: Field label translations #217

Merged
merged 2 commits into from
May 25, 2023
Merged

UHF-8135: Field label translations #217

merged 2 commits into from
May 25, 2023

Conversation

khalima
Copy link
Contributor

@khalima khalima commented May 23, 2023 •
edited by teroelonen
Loading

UHF-8135

What was done

  • Hide menu link translation published -checkbox from news items.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT Admin theme
    • composer require drupal/hdbt_admin:dev-UHF-8135_field_label_translations
  • Run make drush-cr

How to test (in Etusivu instance)

  • Go to create a news item and check that there's no "extra published checkbox" in the edit form like in the picture below
    image
  • Check that code follows our standards

teroelonen
teroelonen approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work 🦖

@khalima khalima merged commit 182bb0b into main May 25, 2023
@khalima khalima deleted the UHF-8135_field_label_translations branch May 25, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khalima @teroelonen