Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-X Media library bug fix #176

Merged
merged 5 commits into from
Nov 16, 2022
Merged

UHF-X Media library bug fix #176

merged 5 commits into from
Nov 16, 2022

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Nov 10, 2022

Media library bug fix

What was done

  • Fixed alignment of edit button on media library widget view.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config and hdbt_admin theme
    • composer require drupal/helfi_platform_config:dev-UHF-X_media_libary_bug_fix
    • composer require drupal/hdbt_admin:dev-UHF-X_media_libary_bug_fix
  • Run make drush-updb drush-cr

How to test

  • Go to add or edit a node and add image paragraph to the node
  • Click on "Add media" and check that the media library links point to correct URLs. F.e. https://helfi-sote.docker.so/en/health-and-social-services/media/308/edit
  • Check that the layout looks ok - previously the edit icons were indented incorrectly
  • Bonus: If you know how to install and use the local proxy (https://github.com/City-of-Helsinki/drupal-helfi-local-proxy), you can try to check the links via local proxy as well. Then the links should point to https://helfi-proxy.docker.so/fi/sosiaali-ja-terveyspalvelut/media/308/edit

Other PRs

Copy link
Contributor

@Arkkimaagi Arkkimaagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended 🚀

@khalima khalima merged commit 51f51f4 into main Nov 16, 2022
@khalima khalima deleted the UHF-X_media_libary_bug_fix branch November 16, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants