Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish docs, add arcgis dependencies #10

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Finish docs, add arcgis dependencies #10

merged 2 commits into from
Mar 28, 2024

Conversation

dnsohrabian
Copy link
Contributor

  • Finished documentation in README about remaining functions and names in modules
  • Adding arcgis package as an install dependency since our ago_helpers module relies on it and imports

@dnsohrabian dnsohrabian marked this pull request as ready for review March 27, 2024 19:31
* `transfer_field` (*str*): The column you are interested in adding from right to left
* `new_name` (*str*): Renaming that transfer field
* `data_type` (*str*, optional): What to cast the value as. Defaults to "string".
'string' for text
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these might look better as sub-bullets

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, it's a little hard to parse through lists right now. I was following the existing format for now but I will add an Issue to revisit in peaceful summer days

@dnsohrabian dnsohrabian self-assigned this Mar 28, 2024
@dnsohrabian dnsohrabian merged commit a2ddb3a into main Mar 28, 2024
1 check passed
@dnsohrabian dnsohrabian deleted the patch1 branch March 28, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants