Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete confirmation #120

Open
inghamn opened this issue Feb 26, 2016 · 2 comments
Open

Delete confirmation #120

inghamn opened this issue Feb 26, 2016 · 2 comments

Comments

@inghamn
Copy link
Member

inghamn commented Feb 26, 2016

We should ask for confirmation before deleting something. Just to avoid accidental clicks.
@inghamn inghamn added this to the 1.1 milestone Feb 26, 2016
inghamn added a commit that referenced this issue Feb 26, 2016
@inghamn
Added javascript delete confirmation prompt.
9a62e2a 
This is really only a hold-over until we can find time to write a better solution.

Updates #120
@inghamn inghamn modified the milestones: 1.1, 1.2 Jul 11, 2016
@charlesbrandt
Copy link
Contributor

It looks like this is complete -- is there something else planned beyond the javascript delete confirmation message?

@inghamn inghamn removed this from the 1.2 milestone Apr 25, 2018
@inghamn
Copy link
Member Author

inghamn commented Apr 25, 2018

We still need a server-side delete confirmation step. If you hit /events/delete?event_id=XXX it just deletes it with no confirmation step.

@inghamn inghamn added this to the 1.2 milestone Jun 14, 2018
@inghamn inghamn modified the milestones: 1.2, 1.2.1, 1.2.2 Jun 28, 2018
@inghamn inghamn removed this from the 1.2.2 milestone Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@inghamn @charlesbrandt