Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_cob_events function causes error when GCal endpoint is down #178

Closed
sethCOB opened this issue Jun 19, 2019 · 1 comment
Closed

_cob_events function causes error when GCal endpoint is down #178

sethCOB opened this issue Jun 19, 2019 · 1 comment

Comments

@sethCOB
Copy link
Member

sethCOB commented Jun 19, 2019

If Google Calendar is down, the page refuses to display and instead returns an error.

For our particular case, I narrowed it down to the _cob_events function in cob.theme.

Since we were in a hurry, my temporary fix was to just comment out the areas of the main theme that called _cob_events until Calendar services were restored. Introducing error handling into the function would help prevent this from taking down the site in the future.
@inghamn inghamn added this to the 1.1.1 milestone Jun 19, 2019
@inghamn
Copy link
Member

inghamn commented Jun 20, 2019

This is a problem with our Google Calendar module for Drupal.

@inghamn inghamn mentioned this issue Jun 20, 2019
Open
inghamn added a commit that referenced this issue Jun 28, 2019
@inghamn
Added try/catch around Google Events call
688423b 
For now, we've added a try/catch.  This is still a problem
that needs to be addressed in the Calendar module.

Updates #178
@inghamn inghamn removed this from the 1.1.1 milestone Jul 11, 2019
@inghamn inghamn closed this as completed Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@inghamn @sethCOB