Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove semantic-ui-react #9894

Merged
merged 4 commits into from
Dec 23, 2024
Merged

Remove semantic-ui-react #9894

merged 4 commits into from
Dec 23, 2024

Conversation

brentguf
Copy link
Contributor

Changelog

Technical

  • Remove the semantic-ui-react library.

@notion-workspace Notion Workspace
Copy link

💅 Dependency clean-up - remove SemanticUI

@cl-dev-bot
Copy link
Collaborator

cl-dev-bot commented Dec 23, 2024 •
edited
Loading

Warnings
⚠️

The changelog is empty. What should I put in the changelog?
⚠️ The PR title contains no Jira issue key (case-sensitive)
Messages
📖 Notion issue: TAN-1316
📖

Run the e2e tests
📖 Check translation progress

Generated by 🚫 dangerJS against 7c89c56

luucvanderzee
luucvanderzee approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@luucvanderzee luucvanderzee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I found some last references to semantic-ui in our reset.css files:

Screenshot 2024-12-23 at 09 57 27

From git blame, I can see that this was added 6 years ago and is indeed coming from some semantic CSS files:

Screenshot 2024-12-23 at 09 58 28

But not sure if we should remove this and risk breaking stuff, and since it's only a few lines maybe not really worth worrying about.

@brentguf
Copy link
Contributor Author

@luucvanderzee The CSS reset files are still used (and necessary). I've removed the comments that mention Semantic though.

@brentguf brentguf merged commit 7f5eb6d into master Dec 23, 2024
10 checks passed
@brentguf brentguf deleted the TAN-1316/remove-semantic-ui-react branch December 23, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luucvanderzee luucvanderzee luucvanderzee approved these changes

Assignees
No one assigned
Labels
fe-performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brentguf @cl-dev-bot @luucvanderzee