Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TAN-3125: Prevent multiple calls to get custom fields on saving a survey #9609

Merged
merged 2 commits into from
Dec 4, 2024
Merged

TAN-3125: Prevent multiple calls to get custom fields on saving a survey #9609

merged 2 commits into from
Dec 4, 2024

Conversation

EdwinKato
Copy link
Contributor

Changelog

Changed

  • Slight improvement in performance by preventing multiple calls to get custom field options after saving a survey

@notion-workspace Notion Workspace
Copy link

Investigate ongoing slowness of survey form editing

EdwinKato
EdwinKato commented Dec 3, 2024
View reviewed changes
front/app/components/FormBuilder/edit/index.tsx
@@ -262,11 +262,9 @@ const FormEdit = ({
},
{
onSuccess: () => {
refetch().then(() => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for a refetch. The invalidation will lead to a refetch

@cl-dev-bot
Copy link
Collaborator

Messages
📖 Changelog provided 🎉
📖 Notion issue: TAN-3125
📖

Run the e2e tests
📖 Check translation progress

Generated by 🚫 dangerJS against b85147e

@EdwinKato EdwinKato requested a review from jamesspeake December 3, 2024 13:03
@EdwinKato EdwinKato merged commit b3206fc into master Dec 4, 2024
15 checks passed
@EdwinKato EdwinKato deleted the TAN-3125-remove-calls-for-custom-fields-on-saving-a-survey branch December 4, 2024 08:17
@EdwinKato EdwinKato added this to the Quality Quest 24Q4 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesspeake jamesspeake jamesspeake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Quality Quest 24Q4
Development

Successfully merging this pull request may close these issues.
3 participants
@EdwinKato @cl-dev-bot @jamesspeake