Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TAN-1824:Update to new twitter icon #9601

Merged
merged 2 commits into from
Dec 4, 2024
Merged

TAN-1824:Update to new twitter icon #9601

merged 2 commits into from
Dec 4, 2024

Conversation

EdwinKato
Copy link
Contributor

Changelog

Changed

  • Update to use new twitter/X icon in the sharing buttons

@notion-workspace Notion Workspace
Copy link

Task - twitter icon should be changed to “X” icon

@EdwinKato EdwinKato requested a review from jamesspeake December 3, 2024 09:50
jamesspeake
jamesspeake approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@jamesspeake jamesspeake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me - did you consider renaming the components? Probably not worth it as Twitter is much easier than X to find in the code + we'll still be calling it twitter in the tracking

@EdwinKato
Copy link
Contributor Author

Looks fine to me - did you consider renaming the components? Probably not worth it as Twitter is much easier than X to find in the code + we'll still be calling it twitter in the tracking

Yeah indeed, I thought about it but it wasn't worth the effort for now. Twitter is easier to find and the library also still uses twitter. We could probably make those changes holistically at some point

@EdwinKato EdwinKato merged commit 230a071 into master Dec 4, 2024
13 of 14 checks passed
@EdwinKato EdwinKato deleted the TAN-1824-update-to-new-twitter-icon branch December 4, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesspeake jamesspeake jamesspeake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EdwinKato @jamesspeake