Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Enchance UX2Config model. #524

Merged
2 commits merged into from
Mar 14, 2024
Merged

Enchance UX2Config model. #524

2 commits merged into from
Mar 14, 2024

Conversation

jpkrajewski
Copy link
Collaborator

@jpkrajewski jpkrajewski commented Mar 14, 2024 •
edited by ghost
Loading

Pull Request summary:

  • Enchance UX2Config model.
  • Create relations between transformed items.
  • Add ERD for UX2Config model.
  • Enhance _get_parcel_type() errror message.
  • Add function that flattens the list of nested feature templates.

Description of changes:

ERD for UX2Config model as of now

diagram

Created relations between items in transformation

diagram drawio

Checklist:

  • Make sure to run pre-commit before committing changes
  • Make sure all checks have passed
  • PR description is clear and comprehensive
  • Mentioned the issue that this PR solves (if applicable)
  • Make sure you test the changes

@jpkrajewski jpkrajewski requested a review from a user March 14, 2024 14:21
@jpkrajewski jpkrajewski changed the title Dev/ux2config model Enchance UX2Config model. Mar 14, 2024
@jpkrajewski jpkrajewski requested review from brdw87 and PrzeG March 14, 2024 14:27
sbasan
sbasan approved these changes Mar 14, 2024
View reviewed changes
catalystwan/models/configuration/feature_profile/sdwan/service/__init__.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think this is needed here. I would go for big stub for whole Configuration Groups top-level models

@ghost ghost merged commit abfb3ed into dev-uxmt Mar 14, 2024
10 checks passed
@ghost ghost deleted the dev/ux2config-model branch March 14, 2024 16:28
@JimOverholt JimOverholt mentioned this pull request Apr 25, 2024
Closed
5 tasks
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sbasan sbasan sbasan approved these changes

@kagrski kagrski Awaiting requested review from kagrski kagrski is a code owner

@JimOverholt JimOverholt Awaiting requested review from JimOverholt JimOverholt is a code owner

@igosoft igosoft Awaiting requested review from igosoft igosoft is a code owner

@bboot2 bboot2 Awaiting requested review from bboot2 bboot2 is a code owner

@brdw87 brdw87 Awaiting requested review from brdw87

@PrzeG PrzeG Awaiting requested review from PrzeG

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpkrajewski @sbasan