This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbasan
reviewed
Feb 13, 2024
catalystwan/endpoints/configuration/feature_profile/sdwan/policy_object.py
Outdated
Show resolved
Hide resolved
catalystwan/models/configuration/feature_profile/sdwan/policy_object/application_list.py
Outdated
Show resolved
Hide resolved
catalystwan/models/configuration/feature_profile/sdwan/policy_object/color_list.py
Outdated
Show resolved
Hide resolved
catalystwan/models/configuration/feature_profile/sdwan/policy_object/color_list.py
Outdated
Show resolved
Hide resolved
catalystwan/models/configuration/feature_profile/sdwan/policy_object/ipv6_prefix_list.py
Outdated
Show resolved
Hide resolved
catalystwan/models/configuration/feature_profile/sdwan/policy_object/prefix_list.py
Outdated
Show resolved
Hide resolved
… server and prase it to a model
… server and prase it to a model
jpkrajewski
force-pushed
the
dev/policy-object
branch
from
February 15, 2024 18:42
33f114b
to
853e7bb
Compare
jpkrajewski
requested review from
kagrski,
JimOverholt and
igosoft
as code owners
February 15, 2024 18:44
sbasan
previously approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
sbasan
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request summary:
Coverage for policy objects
In vManage: Configuration > Policy Groups > Group of Interest
Description of changes:
Added GET, POST, PUT, DELETE methods for Group of Interest
Mapped all models from Group of Interest
Changed
Parcel
to parse data from GET endpointCreated ready to go demo script
How to run a demo:
py .\examples\parcel_configuration_guide.py <ip address> <port> <username> <password>
Created new folder with the models and added top level stub that gives access to them in:
catalystwan\models\configuration\feature_profile\sdwan\interest_groups_init_.py
Checklist: