Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Dev/policy object #463

Merged
merged 31 commits into from
Feb 19, 2024
Merged

Dev/policy object #463

merged 31 commits into from
Feb 19, 2024

Conversation

jpkrajewski
Copy link
Collaborator

@jpkrajewski jpkrajewski commented Feb 12, 2024

Pull Request summary:

Coverage for policy objects
In vManage: Configuration > Policy Groups > Group of Interest
image
image

Description of changes:

  • Added GET, POST, PUT, DELETE methods for Group of Interest

  • Mapped all models from Group of Interest

  • Changed Parcel to parse data from GET endpoint

  • Created ready to go demo script
    How to run a demo: py .\examples\parcel_configuration_guide.py <ip address> <port> <username> <password>

  • Created new folder with the models and added top level stub that gives access to them in:
    catalystwan\models\configuration\feature_profile\sdwan\interest_groups_init_.py

image

Checklist:

  • Make sure to run pre-commit before committing changes
  • Make sure all checks have passed
  • PR description is clear and comprehensive
  • Mentioned the issue that this PR solves (if applicable)
  • Make sure you test the changes

@jpkrajewski jpkrajewski requested a review from sbasan February 14, 2024 13:50
@jpkrajewski jpkrajewski marked this pull request as ready for review February 15, 2024 18:44
sbasan
sbasan previously approved these changes Feb 16, 2024
Copy link
Collaborator

@sbasan sbasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@sbasan sbasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sbasan sbasan merged commit 95184f4 into main Feb 19, 2024
10 checks passed
@sbasan sbasan deleted the dev/policy-object branch February 19, 2024 09:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants