Creating v1.0.0 for Ansible 2.10 base integration #96
Conversation
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
==========================================
+ Coverage 75.66% 76.05% +0.39%
==========================================
Files 47 46 -1
Lines 3838 3763 -75
Branches 1048 1028 -20
==========================================
- Hits 2904 2862 -42
+ Misses 744 720 -24
+ Partials 190 181 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
CI is failing with
\"/tmp/ansible_mso_user_payload_ol7_r2qe/ansible_mso_user_payload.zip/ansible_collections/cisco/mso/plugins/modules/mso_user.py\", line 274, in <module>\n File \"/tmp/ansible_mso_user_payload_ol7_r2qe/ansible_mso_user_payload.zip/ansible_collections/cisco/mso/plugins/modules/mso_user.py\", line 198, in main\n File \"/tmp/ansible_mso_user_payload_ol7_r2qe/ansible_mso_user_payload.zip/ansible_collections/cisco/mso/plugins/module_utils/mso.py\", line 391, in lookup_roles\nAttributeError: 'str' object has no attribute 'get'\n",
plugins/modules/mso_label.py
Outdated
| @@ -19,13 +19,12 @@ | |||
| - Manage labels on Cisco ACI Multi-Site. | |||
| author: | |||
| - Dag Wieers (@dagwieers) | |||
| version_added: '2.8' | |||
| version_added: '0.0.1' | |||
There was a problem hiding this comment.
If these modules existed in github.com/ansible/ansible then this line can be removed.
tests/sanity/ignore-2.10.txt
Outdated
| plugins/modules/mso_schema_template_bd.py validate-modules:invalid-ansiblemodule-schema |
There was a problem hiding this comment.
Great to see these being fixed, thanks :)
There was a problem hiding this comment.
Any idea why I am having to still keep this invalid-ansiblemodule-schema because it seems to complain about a suboption inside a suboption item. Is that not supported?
Update Ansible version in CI and add 2.10.0 to sanity in CI.
Fix sanity issues to support 2.10.0.
Fix M() and module to use FQCN.
Add changelog, bump version and update runtime.yml.
Update README with supported version.
Resolves #90