Feature/collectd addon #1251
Feature/collectd addon #1251
Conversation
| @@ -0,0 +1,4 @@ | |||
| --- | |||
| - hosts: localhost | |||
There was a problem hiding this comment.
Should this really be localhost?
|
Unfortunately, this fails with our Zookeeper checks (which check for |
|
Looks good otherwise, the addon playbook installs correctly and all services remain healthy. We'll just have to remove that distributive check, which will be part of the distributive refactor that's on its way. |
|
@siddharthist is there a way we could remove that check now? Or move it to the collectd checks right away? |
|
It is installed via the monolithic distributive-rpm. If you merge my PRs on mantl-packaging, I can put the new distributive PR in right away, we can merge that and then this. Or, we could remove |
BrianHicks
force-pushed
the
feature/collectd-addon
branch
from
84064c1 to
4589065
Compare
|
Rebased onto latest master |
|
This will be unblocked by #1268, which doesn't check for |
|
now that #1268 is in, we can probably get this merged as soon as the merge conflicts are resolved |
|
Great, I’ll work on that today!
|
BrianHicks
force-pushed
the
feature/collectd-addon
branch
from
4589065 to
cc550cc
Compare
|
this passes most checks but fails on DO for some reason, for different failure scenarios. Weird. |
| - name: check if mesos agent is present | ||
| stat: | ||
| path: /etc/sysconfig/mesos-agent | ||
| register: mesos_agent_present |
There was a problem hiding this comment.
is this being used anywhere?
langston-barrett
force-pushed
the
feature/collectd-addon
branch
from
cc550cc to
51d9119
Compare
|
rebased |
|
@BrianHicks We've seen the most recent DO failure in CI builds before, is that what you were referring to? Is this ready to merge after we fix those variables that @ryane pointed out? |
|
@BrianHicks are the |
$ ag mesos_agent_present
roles/collectd/tasks/mesos-agent.yml
5: register: mesos_agent_present
$ ag mesos_master_present
roles/collectd/tasks/mesos-master.yml
5: register: mesos_master_presentso... no? Do you reckon they ought to be removed? |
|
I kinda think so. they don't break anything but just so there is no confusion... |
Note that this removes the logstash collectd integration. This needed to happen because the Logstash role has become a generic log sink role, and collectd logs are taking up a huge amount of room in that store. We'll need to find a storage solution for collectd at a later date
langston-barrett
force-pushed
the
feature/collectd-addon
branch
from
0ca38b3 to
8d42e95
Compare
|
I changed that, squashed the commit, and rebased. If tests pass, I'll merge. |
|
Well, they all failed, but not for related reasons. |
|
tested successfully on gce |
Testing in progress, I just wanted to get this out here so we can have a discussion: this PR removes logstash's collectd forwarding behavior. Motivation is on 05c49f1. Does anyone have feedback of a better way to do this?