Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create payment api #1

Merged
merged 11 commits into from
Jul 4, 2023
Merged

Create payment api #1

merged 11 commits into from
Jul 4, 2023

Conversation

juanenrisley
Copy link
Collaborator

@juanenrisley juanenrisley commented Jun 29, 2023 •
edited
Loading

Closes #2

  • Create endpoint for funding transactions with Gelato Relayer.
  • Create endpoint for funding Safe deployments.
  • Document Api with Swagger. Accessible with endpoint /docs.

@juanenrisley juanenrisley self-assigned this Jun 29, 2023
llunaCreixent
llunaCreixent previously approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@llunaCreixent llunaCreixent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing usage steps in README. That'd be useful for testing :)

@llunaCreixent llunaCreixent dismissed their stale review June 30, 2023 08:59

missclicked :P

@juanenrisley
Copy link
Collaborator Author

Missing usage steps in README. That'd be useful for testing :)

Updated! ☺️

@llunaCreixent llunaCreixent self-requested a review June 30, 2023 11:54
llunaCreixent
llunaCreixent approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@llunaCreixent llunaCreixent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is beautiful!

@juanenrisley juanenrisley merged commit e27b44b into main Jul 4, 2023
@juanenrisley juanenrisley deleted the create-payment-api branch July 4, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llunaCreixent llunaCreixent llunaCreixent approved these changes

@JacqueGM JacqueGM Awaiting requested review from JacqueGM

Assignees

@juanenrisley juanenrisley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create payment service API for gelato
2 participants
@juanenrisley @llunaCreixent