Add export statement for personal wallet #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for preview-review-circles-garden ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
louilinn
requested changes
Sep 25, 2023
louilinn
previously approved these changes
Sep 25, 2023
|
|
louilinn
reviewed
Sep 26, 2023
src/utils/fileExports.js
Outdated
| data.name = 'CirclesUBI'; | ||
| data.paymentNote = 'UBI payout'; | ||
| data.name = translate('ExportStatement.exportDataName'); | ||
| data.paymentNote = translate('ExportStatement.exportPaymentNote'); |
There was a problem hiding this comment.
now we are adding some text in translations but not all. Maybe then I should add all fields in en.json
louilinn
reviewed
Sep 26, 2023
src/utils/fileExports.js
Outdated
| @@ -203,7 +204,7 @@ export async function downloadCsvStatement( | |||
| ) { | |||
| // Verify date order | |||
| if (startDate > endDate) { | |||
| throw new Error('Invalid date interval'); | |||
| throw new Error(translate('ExportStatement.exportDataName')); | |||
There was a problem hiding this comment.
this was the wrong text so I changed it in a commit
louilinn
force-pushed
the
735-personal-wallet-statement-export
branch
from
47cf009
to
ddeb0af
Compare
louilinn
added a commit
that referenced
this pull request
Sep 28, 2023
* Add export statement for personal wallet * Specify UBI payouts in export for personal wallets * Move all statement file text to en.json --------- Co-authored-by: Louise Linné <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently build on:
https://preview-dev.circles.garden/activities