Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

731 multi token display pocmvp #734

Merged
merged 10 commits into from
Oct 5, 2023
Merged

731 multi token display pocmvp #734

merged 10 commits into from
Oct 5, 2023

Conversation

louilinn
Copy link
Collaborator

@louilinn louilinn commented Sep 20, 2023 •
edited by mikozet
Loading

Drafting PR to auto-deploy preview

  • Integrete ProfileMini component with ActivityItem so they look the same
  • Remove underline style on balance for firefox

@louilinn louilinn linked an issue Sep 20, 2023 that may be closed by this pull request
Multi-token display POC/MVP #731
Closed
@netlify
Copy link

netlify bot commented Sep 20, 2023 •
edited
Loading

✅ Deploy Preview for preview-review-circles-garden ready!

Name Link
🔨 Latest commit 7bfcb00
🔍 Latest deploy log https://app.netlify.com/sites/preview-review-circles-garden/deploys/651e9b6b13c51c000851c706
😎 Deploy Preview https://deploy-preview-734.review.circles.garden
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@louilinn louilinn marked this pull request as ready for review September 21, 2023 12:10
louilinn
louilinn commented Sep 21, 2023
View reviewed changes
Copy link
Collaborator Author

@louilinn louilinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a first improvement on how to exclude almost 0 balances and reverse sorting

src/store/token/actions.js Show resolved Hide resolved
@mikozet mikozet force-pushed the 731-multi-token-display-pocmvp branch from bf1cb67 to 6f96407 Compare September 21, 2023 13:01
@mikozet
Copy link
Collaborator

mikozet commented Sep 21, 2023

As a first improvement on how to exclude almost 0 balances and reverse sorting

doesn't work for the moment excluding zero - but we decided with Jacque that she will do it on backend side...

@mikozet mikozet force-pushed the 731-multi-token-display-pocmvp branch from 6f96407 to 9d5abf7 Compare September 22, 2023 08:54
@mikozet
Copy link
Collaborator

mikozet commented Sep 25, 2023

As a first improvement on how to exclude almost 0 balances and reverse sorting

doesn't work for the moment excluding zero - but we decided with Jacque that she will do it on backend side...

Later decided it will be frontend side

mikozet
mikozet previously approved these changes Sep 25, 2023
View reviewed changes
@juanenrisley
Copy link
Collaborator

As a first improvement on how to exclude almost 0 balances and reverse sorting

doesn't work for the moment excluding zero - but we decided with Jacque that she will do it on backend side...

Later decided it will be frontend side

Maybe it is not working because the token amount returned by the core is a BN and it is not what the method formatCirclesValue is expecting

juanenrisley
juanenrisley previously approved these changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@juanenrisley juanenrisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏿 LGTM

@louilinn louilinn dismissed stale reviews from juanenrisley and mikozet via 5a336a2 September 28, 2023 09:57
@louilinn
Copy link
Collaborator Author

Currently awaiting new display text from Lucia in the tokens view. The rest of the visuals and behaviors are approved.

@louilinn
Copy link
Collaborator Author

We will have to remake this PR after merging news with new branch from main and cherry-picked commits

@louilinn
Copy link
Collaborator Author

Closes #739

juanenrisley
juanenrisley previously approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@juanenrisley juanenrisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏿 LGTM

@louilinn louilinn force-pushed the 731-multi-token-display-pocmvp branch from b6fe8a3 to fffee6e Compare October 5, 2023 08:30
@louilinn
Copy link
Collaborator Author

louilinn commented Oct 5, 2023

News update:
title: Balance Breakdown
date: 06.10.2023
message:

We are proud to present you with a new feature! When clicking on your circles balance you can now see a breakdown of whose circles you actually hold.

All circles are originally issued as someone’s UBI. Circles can be most easily transferred to the issuer and the ones trusting the issuer. If you ever face trouble with a transaction, this feature may help you understand the reason why. By exploring what circles you hold and compare it to the mutually trusted connections of the account you want to send circles to, you might be able to see by yourself, if you hold enough circles that this person is actually accepting.

Learn more.

Enjoy!

juanenrisley
juanenrisley approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@juanenrisley juanenrisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏿

@louilinn louilinn changed the base branch from main to release October 5, 2023 11:16
@louilinn louilinn force-pushed the 731-multi-token-display-pocmvp branch from febf8f8 to 7bfcb00 Compare October 5, 2023 11:18
@louilinn louilinn merged commit 388d15d into release Oct 5, 2023
4 checks passed
@louilinn louilinn deleted the 731-multi-token-display-pocmvp branch October 5, 2023 13:00
louilinn added a commit that referenced this pull request Oct 5, 2023
@louilinn @mikozet
731 multi token display pocmvp (#734)
60042ed 
* Add multi token display functionality

* Add underline on balance for hover

* Change tooltip and notification UBI info from monthly rate to daily

* Replace seed phrase with magic words consistently

* Add Balance Breakdown link to token display in Navigation

* Fix console error in Welcome view

---------

Co-authored-by: miko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanenrisley juanenrisley juanenrisley approved these changes

@mikozet mikozet mikozet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi-token display POC/MVP
3 participants
@louilinn @mikozet @juanenrisley