Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read response pathfinder2 #196

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

llunaCreixent
Copy link
Member

@llunaCreixent llunaCreixent commented May 15, 2023

Instead of responding a json, the pathfinder2 instance responds with a TransferThrough object that is readable. This object is parsed in the pathfinder-proxy to json. Since the pathfinder2 doesn't support the iterative option, there is no problem with parsing the response. However if we want to use the iterative option we need to process the readable object. The new method processResponseNdjson reads the response of the pathfinder2 and returns only one json.

Closes #182

Missing tasks:

  • clean console.log
  • Check if we need more tests
  • Review error handling
  • assess the need for pathfinder method called cancel(id)

@llunaCreixent llunaCreixent marked this pull request as ready for review May 15, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leverage of the iterative option of the pathfinder
1 participant