20240207 invite as org #87
Conversation
|
that seems to be now 🎉 |
| function inviteHumanAsOrganization(address _human, address payable _donationReceiver) external payable { | ||
| require(msg.value > MINIMUM_DONATION, "Donation must be at least 0.1 xDai."); | ||
| require(isOrganization(msg.sender), "Only organizations can invite."); | ||
|
|
There was a problem hiding this comment.
| require(msg.sender != _donationReceiver, "Can't donate to yourself"); |
There was a problem hiding this comment.
Makes it at least a little bit more expensive to perpetually invite people with the same funds.
There was a problem hiding this comment.
well, I agree, but you can always send to yourself over one-hop, so I don't know if we should block it. we already know that the donation is a reputation requirement for it to have meaning
There was a problem hiding this comment.
I added the requirement with comment
src/hub/Hub.sol
Outdated
|
|
||
| // set the last mint time to the current timestamp for invited human | ||
| // and register the v1 Circles contract status | ||
| address v1CirclesStatus = _avatarV1CirclesStatus(_human); |
There was a problem hiding this comment.
Let's refactor the common parts of inviteHuman and inviteHumanAsOrganization into an _inviteHuman function
There was a problem hiding this comment.
yes, I wanted to, but then thought I was overthinking it. Ill quickly do
There was a problem hiding this comment.
turned out it was well worth the refactoring!
I ll rebase this once the other PR is also on develop, thanks @jaensen / ✅ done