Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

group mint #111

Merged
merged 16 commits into from
Mar 6, 2024
Merged

group mint #111

merged 16 commits into from
Mar 6, 2024

Conversation

benjaminbollen
Copy link
Member

@benjaminbollen benjaminbollen commented Feb 23, 2024 •
edited
Loading

fixes #110

@benjaminbollen benjaminbollen linked an issue Feb 23, 2024 that may be closed by this pull request
group mint #110
Closed
4 tasks
@benjaminbollen benjaminbollen mentioned this pull request Feb 27, 2024
Closed
@benjaminbollen benjaminbollen linked an issue Feb 27, 2024 that may be closed by this pull request
remove invite by organization #109
Closed
@benjaminbollen
Copy link
Member Author

Unsure why these CI tests fail on forge fmt --check because I have triple checked locally that all fmt is applied... I ll figure out later why this fails

@benjaminbollen
Copy link
Member Author

thanks @jaensen for figuring this one out!

@benjaminbollen benjaminbollen marked this pull request as ready for review February 29, 2024 19:47
jaensen
jaensen approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@jaensen jaensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - but surely a lot of new stuff for me 😅

@jaensen jaensen merged commit 3d0906d into develop Mar 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaensen jaensen jaensen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
circles-contracts-v2
Status: 💪Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

group mint remove invite by organization
2 participants
@benjaminbollen @jaensen