Fix/expose volume type #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leaving default value as gp3 since that was the hardcoded value and existing clusters may have successfully spun up with this value.
ryanwohara
approved these changes
Mar 17, 2021
lloydChris
suggested changes
Mar 17, 2021
There was a problem hiding this comment.
Looks good. Should also add it to the inputs section of the readme: https://github.com/CircleCI-Public/server-terraform/tree/main/nomad-aws#inputs
ah! good catch. lemme do that done! |
lloydChris
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚙️ Issue
The volume type "gp3" isn't currently supported in AWS launch configurations in all regions.
See here for more info
✅ Fix
swapped the hardcoded volume-type for a variable which an operator may update
Notes:
Left the default value as gp3 in case there are any existing clusters with this volume type.