Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lts cannot be specified by node-version at node/install #132

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

yasuoza
Copy link
Contributor

@yasuoza yasuoza commented Mar 4, 2022

SEMVER Update Type:

  • Major
  • Minor
  • Patch

Description:

Document says

 To install the latest LTS version, set the version to `lts`.

https://circleci.com/developer/ja/orbs/orb/circleci/node?version=5.0.0#commands-install

But, node-version: lts fails with following error.

Version 'lts' not found - try `nvm ls-remote` to browse available versions.

Exited with code exit status 3

This is causes by script does not handle node-version: lts well.
This PR fixes the issue.

Motivation:

I want to set and fix node version lts, but with version 5.0.0, I can't.

Checklist:

  • All new jobs, commands, executors, parameters have descriptions.
  • Usage Example version numbers have been updated.
  • Changelog has been updated.

@yasuoza yasuoza requested a review from a team as a code owner March 4, 2022 07:21
@Jaryt
Copy link
Contributor

Jaryt commented Mar 11, 2022

Hi! Thank you for bringing this up. I believe this is actually due to me missing that documentation that was leftover from the change to default to lts rather than latest. To use 'lts', the node-version string would remain empty. I'm trying to decide whether it's worth adding this check in case someone does set the string to lts.

Regardless, I'll need to fix that piece of documentation.

@Jaryt Jaryt changed the base branch from master to fix/yarn-and-cache March 14, 2022 19:10
@Jaryt Jaryt merged commit e3bd018 into CircleCI-Public:fix/yarn-and-cache Mar 14, 2022
@Jaryt
Copy link
Contributor

Jaryt commented Mar 14, 2022

Updated the comment and merged since it wouldn't hurt if someone explicitly defined the version as lts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants