Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RT-603] Migrate CLI to use runner.circleci.com #742

Merged

Conversation

afranco07
Copy link
Contributor

Jira: RT-603

As part of the incident remediation for Runner UI & CLI making requests to the wrong domain, migrate the CLI to use runner.circleci.com for runner related operations. This is needed as the infra team starts to depreacate www-proxy.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Changes

  • Check if runner host matches cloud url (i.e. https://circleci.com`). If it matches then replace it with https://runner.circleci.com

Rationale

As part of the incident remediation for Runner UI & CLI making requests to the wrong domain, migrate the CLI to use runner.circleci.com for runner related operations. This is needed as the infra team starts to depreacate www-proxy.

Considerations

Went with using this method so as to not break the CLI when using server installations and not break other commands that still use https://circleci.com

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #742 (c8f4121) into master (25ac45c) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #742      +/-   ##
==========================================
- Coverage   31.78%   31.75%   -0.03%     
==========================================
  Files          44       44              
  Lines        5327     5331       +4     
==========================================
  Hits         1693     1693              
- Misses       3384     3388       +4     
  Partials      250      250              
Impacted Files Coverage Δ
cmd/runner/runner.go 56.25% <0.00%> (-18.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25ac45c...c8f4121. Read the comment docs.

@afranco07 afranco07 marked this pull request as ready for review June 29, 2022 21:19
@afranco07 afranco07 requested a review from a team as a code owner June 29, 2022 21:19
@afranco07 afranco07 force-pushed the RT-603/migrate-runner-host branch from b5f1596 to d0e54bf Compare June 29, 2022 21:20
Jira: [RT-603](https://circleci.atlassian.net/browse/RT-603)

As part of the incident remediation for [Runner UI & CLI making requests to the wrong domain](https://circleci.atlassian.net/l/c/ou0ABPYK), migrate the CLI to use `runner.circleci.com` for runner related operations. This is needed as the infra team starts to depreacate `www-proxy`.
@afranco07 afranco07 force-pushed the RT-603/migrate-runner-host branch from d0e54bf to 1df15f6 Compare July 1, 2022 15:06
@jrahme-cci jrahme-cci force-pushed the RT-603/migrate-runner-host branch from 5d56384 to c8f4121 Compare July 4, 2022 17:13
@jrahme-cci jrahme-cci merged commit ee1f054 into CircleCI-Public:master Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants