Skip to content

Commit

Permalink
fix(port): update config to allow env ports (#212)
Browse files Browse the repository at this point in the history
* fix(port): update config to allow env ports

* Fix type for default in port

* Fix type for default in port

---------

Co-authored-by: Mateo Arboleda <[email protected]>
  • Loading branch information
bassrock and marboledacci authored Aug 22, 2024
1 parent db7b3ff commit ad1fb15
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/commands/update_service.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ parameters:
description: >
The port of the container to be load-balanced via AWS CodeDeploy.
Only effective when the deployment_controller parameter value is "CODE_DEPLOY".
type: integer
default: 80
type: string
default: "80"
container_image_name_updates:
description: >
Use this to update the Docker image names and/or tag names of existing containers that had been defined in the previous task definition.
Expand Down
4 changes: 2 additions & 2 deletions src/jobs/deploy_service_update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ parameters:
Only effective when the deployment_controller parameter value is
"CODE_DEPLOY".
type: integer
default: 80
type: string
default: "80"
container_image_name_updates:
description: >
Use this to update the Docker image names and/or tag names of existing
Expand Down
1 change: 1 addition & 0 deletions src/scripts/update_bluegreen_service_via_task_def.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ ORB_STR_CD_CAPACITY_PROVIDER_WEIGHT="$(circleci env subst "$ORB_STR_CD_CAPACITY_
ORB_STR_CD_CAPACITY_PROVIDER_BASE="$(circleci env subst "$ORB_STR_CD_CAPACITY_PROVIDER_BASE")"
ORB_STR_CD_DEPLOYMENT_CONFIG_NAME="$(circleci env subst "$ORB_STR_CD_DEPLOYMENT_CONFIG_NAME")"
ORB_STR_PROFILE_NAME="$(circleci env subst "$ORB_STR_PROFILE_NAME")"
ORB_INT_CD_LOAD_BALANCED_CONTAINER_PORT="$(circleci env subst "$ORB_INT_CD_LOAD_BALANCED_CONTAINER_PORT")"

DEPLOYED_REVISION="${CCI_ORB_AWS_ECS_REGISTERED_TASK_DFN}"

Expand Down

0 comments on commit ad1fb15

Please sign in to comment.