refac(invoke-preprocessing.ps1): make code shorter and cleaner

[momcilovicluka]

Type of Change

• New feature
• Bug fix
• Documentation update
• Refactoring
• Hotfix
• Security patch
• UI/UX improvement

Description

Refactor: tools/Invoke-Preprocessing.ps1
Simplify code and make it shorter

Testing

Test by running compile before and after along with custom Write-Output to ensure that files being processed are the same and that there is no behaviour change

Impact

Issue related to PR

• Resolves #

Additional Information

Checklist

• My code adheres to the coding and style guidelines of the project.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation.
• My changes generate no errors/warnings/merge conflicts.

[ruxunderscore]

#2813 Completely rewrites the this file as well. Was breaking under some versions of Powershell. I recommend closing this one, or refactoring based on the mentioned PR, if you still feel that there needs to be some shortening of code. That being said, be careful what you shorten, as sometimes that also makes the code less readable and/or hard-coded. I do like the implementation of foreach over the previous for loop for excluded file validation.

[momcilovicluka]

CLOSED IN FAVOR OF #2813

Thanks for the review and advice. I wasn't aware of the other PR. I agree with your recommendation. I shall make suggestions to the aforementioned PR if need be.