Import Bugfix: Change Preset Type and contains check #2789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will the exported .json still work after this update? |
Yes, the export function didn't change in any way |
nice |
ChrisTitusTech
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
When the Powershell Tweaks Import didn't work reliably because until now, all of the imported tweaks were stored as a long string and searched for a substring. This resulted in both powershell tweaks being selected because the Internal tweak names are quite similar.
Now, all the tweaks are loaded as an array, and checked for an exact match to fix the issue
Testing
Created an Export of Applications / Tweaks and Features, cleared all checkmarks, imported them and checked if they are the same
Issue related to PR